meonkeys commented on code in PR #5701: URL: https://github.com/apache/fineract/pull/5701#discussion_r3012854805
########## README.md: ########## @@ -88,8 +91,8 @@ How to run for local development Run the following commands in this order: ```bash -./gradlew createDB -PdbName=fineract_tenants -./gradlew createDB -PdbName=fineract_default +./gradlew :fineract-provider:createPGDB -PdbName=fineract_tenants Review Comment: use the short task name here too ########## README.md: ########## @@ -59,20 +59,23 @@ Follow these steps to quickly set up and run Apache Fineract locally: ### Prerequisites - Java 21 or higher -- PostgreSQL or MariaDB running locally +- PostgreSQL running locally ### Clone the repository ```bash git clone https://github.com/apache/fineract.git cd fineract ``` -### Create databases +### Database setup (PostgreSQL) + ```bash -./gradlew createDB -PdbName=fineract_tenants -./gradlew createDB -PdbName=fineract_default +./gradlew :fineract-provider:createPGDB -PdbName=fineract_tenants +./gradlew :fineract-provider:createPGDB -PdbName=fineract_default Review Comment: The `createPGDB` task is unique, so `:fineract-provider:createPGDB` can be shortened to `createPGDB`. ########## README.md: ########## @@ -59,20 +59,23 @@ Follow these steps to quickly set up and run Apache Fineract locally: ### Prerequisites - Java 21 or higher -- PostgreSQL or MariaDB running locally +- PostgreSQL running locally ### Clone the repository ```bash git clone https://github.com/apache/fineract.git cd fineract ``` -### Create databases +### Database setup (PostgreSQL) + ```bash -./gradlew createDB -PdbName=fineract_tenants -./gradlew createDB -PdbName=fineract_default +./gradlew :fineract-provider:createPGDB -PdbName=fineract_tenants +./gradlew :fineract-provider:createPGDB -PdbName=fineract_default ``` +> Note: This task requires PostgreSQL to be properly configured. You may need to set environment variables such as FINERACT_HIKARI_USERNAME and FINERACT_HIKARI_PASSWORD. The default configuration used in CI is root / postgres. Additionally, an initial database (e.g. root) may need to exist for the connection to succeed. Review Comment: > Additionally, an initial database (e.g. root) may need to exist for the connection to succeed. Really? And it's not there by default? That's news to me. Please confirm this or remove this sentence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
