DeathGun44 commented on code in PR #5733:
URL: https://github.com/apache/fineract/pull/5733#discussion_r3031556543
##########
.gitignore:
##########
@@ -34,4 +34,10 @@ gradleExp/
.run/
.java-version
-.windsurf/
\ No newline at end of file
+.windsurf/allure-report*/
Review Comment:
i dont think these gitignore changes are required in this pr
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/fixeddeposit/FixedDepositAccountHelper.java:
##########
@@ -655,4 +655,15 @@ public Long undoFixedDepositTransaction(final Integer
fixedDepositAccountId, fin
.getResourceId();
}
+ public Long adjustFixedDepositTransaction(final Integer
fixedDepositAccountId, final Integer transactionId,
+ final String transactionDate, final Double transactionAmount) {
+ LOG.info("--------------------------------- ADJUST FIXED DEPOSIT
TRANSACTION --------------------------------");
+ final
org.apache.fineract.client.models.PostFixedDepositAccountsFixedDepositAccountIdTransactionsRequest
request = new
org.apache.fineract.client.models.PostFixedDepositAccountsFixedDepositAccountIdTransactionsRequest()
Review Comment:
here its better to use a proper import
##########
.gitignore:
##########
@@ -34,4 +34,10 @@ gradleExp/
.run/
.java-version
-.windsurf/
\ No newline at end of file
+.windsurf/allure-report*/
+allure-results*/
+*.log
+*.txt
Review Comment:
these will remove banner.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
