adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060219278
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java:
##########
@@ -186,6 +193,39 @@ public CommandProcessingResult deleteLoanApplication(
return deleteLoanApplication(null, loanExternalId);
}
+ @GET
+ @Path("{loanId}/delinquencyrangetags")
+ @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+ @Produces(MediaType.APPLICATION_JSON)
+ @Operation(summary = "Retrieve the Loan Delinquency Tag history using the
Loan Id", description = "", operationId =
"getDelinquencyRangeScheduleTagHistoryById")
+ @ApiResponses({
+ @ApiResponse(responseCode = "200", description = "OK", content =
@Content(array = @ArraySchema(schema = @Schema(implementation =
WorkingCapitalLoanApiResourceSwagger.GetWorkingCapitalLoanDelinquencyRangeScheduleTagHistoryResponse.class))))
})
+ public Collection<WorkingCapitalLoanDelinquencyTagHistoryData>
getDelinquencyRangeScheduleTagHistoryById(
Review Comment:
Please return List, no Collection...
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java:
##########
@@ -186,6 +193,39 @@ public CommandProcessingResult deleteLoanApplication(
return deleteLoanApplication(null, loanExternalId);
}
+ @GET
+ @Path("{loanId}/delinquencyrangetags")
+ @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+ @Produces(MediaType.APPLICATION_JSON)
+ @Operation(summary = "Retrieve the Loan Delinquency Tag history using the
Loan Id", description = "", operationId =
"getDelinquencyRangeScheduleTagHistoryById")
+ @ApiResponses({
+ @ApiResponse(responseCode = "200", description = "OK", content =
@Content(array = @ArraySchema(schema = @Schema(implementation =
WorkingCapitalLoanApiResourceSwagger.GetWorkingCapitalLoanDelinquencyRangeScheduleTagHistoryResponse.class))))
})
+ public Collection<WorkingCapitalLoanDelinquencyTagHistoryData>
getDelinquencyRangeScheduleTagHistoryById(
+ @PathParam("loanId") @Parameter(description = "loanId", required =
true) final Long loanId, @Context final UriInfo uriInfo) {
+ return getDelinquencyRangeScheduleTagHistory(loanId, null, uriInfo);
+ }
+
+ @GET
+ @Path("external-id/{externalId}/delinquencyrangetags")
+ @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+ @Produces(MediaType.APPLICATION_JSON)
+ @Operation(summary = "Retrieve the Loan Delinquency Tag history using the
Loan Id", description = "", operationId =
"getDelinquencyRangeScheduleTagHistoryById")
+ @ApiResponses({
+ @ApiResponse(responseCode = "200", description = "OK", content =
@Content(array = @ArraySchema(schema = @Schema(implementation =
WorkingCapitalLoanApiResourceSwagger.GetWorkingCapitalLoanDelinquencyRangeScheduleTagHistoryResponse.class))))
})
+ public Collection<WorkingCapitalLoanDelinquencyTagHistoryData>
getDelinquencyRangeScheduleTagHistoryById(
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
