adamsaghy commented on code in PR #5761:
URL: https://github.com/apache/fineract/pull/5761#discussion_r3187530112
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsHelper.java:
##########
@@ -126,37 +127,37 @@ private LocalDate
determineInterestPostingPeriodEndDateFrom(final LocalDate peri
case INVALID:
break;
case DAILY:
- // produce period end date on current day
- periodEndDate = periodStartDate;
+ // interest posting occurs on the next day after current day
+ periodEndDate = periodStartDate.plusDays(1);
Review Comment:
These changes looks quite breaking ones... you are effectively shifting all
period end date by 1 day. Why??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
