Aman-Mittal commented on code in PR #5826: URL: https://github.com/apache/fineract/pull/5826#discussion_r3201613375
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0233_backfill_repayment_start_date_type_on_loan.xml: ########## @@ -0,0 +1,115 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.3.xsd";> + + <changeSet author="fineract" id="0233-step-2-backfill-repayment-start-date-type-mysql-mariadb" dbms="mysql,mariadb" + runInTransaction="false"> + <preConditions onFail="MARK_RAN"> + <and> + <tableExists tableName="m_loan"/> + <tableExists tableName="m_product_loan"/> + <columnExists tableName="m_loan" columnName="repayment_start_date_type_enum"/> + <columnExists tableName="m_product_loan" columnName="repayment_start_date_type_enum"/> + </and> + </preConditions> + <sql splitStatements="false"> + CREATE PROCEDURE backfill_repayment_start_date_type_on_loan() + BEGIN + DECLARE v_rows_updated INT DEFAULT 1; + + WHILE v_rows_updated > 0 DO + UPDATE m_loan l + INNER JOIN ( + SELECT l2.id, lp2.repayment_start_date_type_enum + FROM m_loan l2 + INNER JOIN m_product_loan lp2 ON lp2.id = l2.product_id + WHERE l2.repayment_start_date_type_enum IS NULL + AND lp2.repayment_start_date_type_enum IS NOT NULL + ORDER BY l2.id + LIMIT 10000 + ) batch ON batch.id = l.id + SET l.repayment_start_date_type_enum = batch.repayment_start_date_type_enum; + + SET v_rows_updated = ROW_COUNT(); + COMMIT; + END WHILE; + END; + </sql> + <sql>CALL backfill_repayment_start_date_type_on_loan();</sql> + <sql>DROP PROCEDURE backfill_repayment_start_date_type_on_loan;</sql> + </changeSet> + + <changeSet author="fineract" id="0233-step-2-backfill-repayment-start-date-type" context="postgresql" runInTransaction="false"> + <preConditions onFail="MARK_RAN"> + <and> + <tableExists tableName="m_loan"/> + <tableExists tableName="m_product_loan"/> + <columnExists tableName="m_loan" columnName="repayment_start_date_type_enum"/> + <columnExists tableName="m_product_loan" columnName="repayment_start_date_type_enum"/> + </and> + </preConditions> + <sql splitStatements="false"> + DO $$ Review Comment: Hi, thanks for replying, pls resolve this comment when it gets reviewed by adam If possible can you share any data snapshot in which I can test these too? Asking for myself so that I can fiddle around with schema locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
