vidakovic commented on code in PR #5773: URL: https://github.com/apache/fineract/pull/5773#discussion_r3257664383
########## fineract-investor/src/main/java/org/apache/fineract/investor/data/request/ExternalAssetOwnerBuybackRequest.java: ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fineract.investor.data.request; + +import io.swagger.v3.oas.annotations.media.Schema; +import jakarta.validation.constraints.NotBlank; +import jakarta.validation.constraints.Size; +import java.io.Serial; +import java.io.Serializable; +import lombok.AllArgsConstructor; +import lombok.Builder; +import lombok.Data; +import lombok.NoArgsConstructor; + +@Builder +@Data +@NoArgsConstructor +@AllArgsConstructor +public class ExternalAssetOwnerBuybackRequest implements Serializable { + + @Serial + private static final long serialVersionUID = 1L; + + private Long loanId; + + @NotBlank(message = "{org.apache.fineract.investor.transfer.settlement-date.not-null}") + private String settlementDate; + + @Size(max = 100, message = "{org.apache.fineract.investor.transfer.transfer-external-id.size}") + private String transferExternalId; + + @Schema(example = "yyyy-MM-dd") Review Comment: Let's stick with Jakarta validation and remove those @Schema annotations from the Swagger library. It gets then very confusion to see which one is for what... the only potential use case for the Swagger stuff here would be showing examples... usually they are trivial, so let's skip that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
