vidakovic commented on code in PR #5773:
URL: https://github.com/apache/fineract/pull/5773#discussion_r3257747217
##########
fineract-investor/src/test/java/org/apache/fineract/investor/service/ExternalAssetOwnerLoanProductAttributesWriteServiceImplTest.java:
##########
@@ -334,6 +327,44 @@ private void assertLoanProductAttributeValues(final
TestContext testContext,
Assertions.assertEquals(testContext.attributeValue,
loanProductAttribute.getAttributeValue());
}
+ private void createExternalAssetOwnerLoanProductAttribute(final
TestContext testContext, final JsonCommand command) {
Review Comment:
In the moment we see anything `JsonCommand` then the refactoring was not
done successfully. `JsonCommand`, `CommandWrapper`, `CommandBuilder`... all
these and similar are exactly the classes we want to get rid of, because they
are not type safe (which is the primary goal of this task).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
