vidakovic commented on code in PR #5856: URL: https://github.com/apache/fineract/pull/5856#discussion_r3261820413
########## fineract-provider/src/main/java/org/apache/fineract/portfolio/collateralmanagement/service/CollateralManagementWriteServiceImpl.java: ########## @@ -0,0 +1,146 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.collateralmanagement.service; + +import java.math.BigDecimal; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import lombok.RequiredArgsConstructor; +import org.apache.fineract.infrastructure.core.data.ApiParameterError; +import org.apache.fineract.infrastructure.core.data.DataValidatorBuilder; +import org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException; +import org.apache.fineract.organisation.monetary.domain.ApplicationCurrency; +import org.apache.fineract.organisation.monetary.domain.ApplicationCurrencyRepository; +import org.apache.fineract.portfolio.collateralmanagement.api.CollateralManagementJsonInputParams; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductCreateRequest; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductCreateResponse; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductDeleteRequest; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductDeleteResponse; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductUpdateRequest; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductUpdateResponse; +import org.apache.fineract.portfolio.collateralmanagement.data.CollateralProductUpdateResponse.Changes; +import org.apache.fineract.portfolio.collateralmanagement.domain.ClientCollateralManagement; +import org.apache.fineract.portfolio.collateralmanagement.domain.CollateralManagementDomain; +import org.apache.fineract.portfolio.collateralmanagement.domain.CollateralManagementRepositoryWrapper; +import org.apache.fineract.portfolio.collateralmanagement.exception.CollateralCannotBeDeletedException; +import org.apache.fineract.portfolio.collateralmanagement.exception.CollateralNotFoundException; + +@RequiredArgsConstructor +public class CollateralManagementWriteServiceImpl implements CollateralManagementWriteService { + + private final CollateralManagementRepositoryWrapper collateralManagementRepositoryWrapper; + private final ApplicationCurrencyRepository applicationCurrencyRepository; + + @Override + public CollateralProductCreateResponse createCollateralProduct(final CollateralProductCreateRequest request) { + validateForCreation(request); + + final ApplicationCurrency applicationCurrency = this.applicationCurrencyRepository.findOneByCode(request.getCurrency()); + final CollateralManagementDomain collateral = CollateralManagementDomain.createNew(request.getName(), request.getQuality(), + request.getBasePrice(), request.getUnitType(), request.getPctToBase(), applicationCurrency); + this.collateralManagementRepositoryWrapper.create(collateral); + + return CollateralProductCreateResponse.builder().resourceId(collateral.getId()).build(); + } + + @Override + public CollateralProductUpdateResponse updateCollateralProduct(final CollateralProductUpdateRequest request) { + final CollateralManagementDomain collateral = this.collateralManagementRepositoryWrapper.getCollateral(request.getCollateralId()); + final ApplicationCurrency applicationCurrency = request.getCurrency() != null + ? this.applicationCurrencyRepository.findOneByCode(request.getCurrency()) + : collateral.getCurrency(); + final Map<String, Object> changes = collateral.update(request.getName(), request.getQuality(), request.getUnitType(), + request.getBasePrice(), request.getPctToBase(), applicationCurrency); + this.collateralManagementRepositoryWrapper.update(collateral); + + return CollateralProductUpdateResponse.builder().resourceId(request.getCollateralId()).changes(toChanges(changes)).build(); + } + + private static Changes toChanges(final Map<String, Object> changes) { + return Changes.builder() // + .name((String) changes.get(CollateralManagementJsonInputParams.NAME.getValue())) // + .quality((String) changes.get(CollateralManagementJsonInputParams.QUALITY.getValue())) // + .basePrice((BigDecimal) changes.get(CollateralManagementJsonInputParams.BASE_PRICE.getValue())) // + .unitType((String) changes.get(CollateralManagementJsonInputParams.UNIT_TYPE.getValue())) // + .pctToBase((BigDecimal) changes.get(CollateralManagementJsonInputParams.PCT_TO_BASE.getValue())) // + .currency((String) changes.get(CollateralManagementJsonInputParams.CURRENCY.getValue())) // + .build(); + } + + @Override + public CollateralProductDeleteResponse deleteCollateralProduct(final CollateralProductDeleteRequest request) { + final CollateralManagementDomain collateral = this.collateralManagementRepositoryWrapper.getCollateral(request.getCollateralId()); + validateForDeletion(collateral, request.getCollateralId()); + this.collateralManagementRepositoryWrapper.delete(request.getCollateralId()); + + return CollateralProductDeleteResponse.builder().resourceId(request.getCollateralId()).build(); + } + + private void validateForCreation(final CollateralProductCreateRequest request) { Review Comment: This can be done with Jakarta Validation annotations! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
