udayagiri-sivasai-dev commented on PR #5763: URL: https://github.com/apache/fineract/pull/5763#issuecomment-4523415411
> ``` > > (see https://errorprone.info/bugpattern/InlineMeSuggester) > Did you mean '@InlineMe(replacement = "!this.isActive()")'? > /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/core/exception/ErrorHandler.java:99: error: [UnusedMethod] Method 'getSqlClassCode' is never used. > private static String getSqlClassCode(SQLException ex) { > ^ > (see https://errorprone.info/bugpattern/UnusedMethod) > Did you mean to remove this line? > /home/runner/work/fineract/fineract/fineract-core/src/main/java/org/apache/fineract/infrastructure/core/exception/ErrorHandler.java:78: error: [ImmutableEnumChecker] enums should be immutable: 'PessimisticLockingFailureCode' has field 'msgs' of type 'java.lang.String[]', arrays are mutable > private final String[] msgs; > ^ > (see https://errorprone.info/bugpattern/ImmutableEnumChecker) > ``` Updated the implementation to address the ErrorProne feedback. The HY00 case now stores messages as an immutable List instead of a String array, and the unused helper method was removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
