adamsaghy commented on code in PR #5883:
URL: https://github.com/apache/fineract/pull/5883#discussion_r3298363656
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java:
##########
@@ -556,6 +557,27 @@ public static final class Registration implements
Serializable {
}
}
+ @Getter
+ @Setter
+ public static class FineractSecurityOidcFederationProperties {
Review Comment:
This looks messy to me...
Why should we have any of the below fields as configuration:
- tenantClaimName -> There should be no default value
- usernameClaim -> There should be no default value
- autoCreateUser -> There should be no such functionality as part of OIDC,
maybe as a follow-up...
- defaultRoles? -> No default roles... security nightmare AS-IS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
