vidakovic commented on code in PR #5811:
URL: https://github.com/apache/fineract/pull/5811#discussion_r3310157850


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/account/api/AccountTransfersApiResource.java:
##########
@@ -70,7 +75,6 @@ public class AccountTransfersApiResource {
             + 
"accounttransfers/template?fromClientId=1&fromAccountType=2&fromAccountId=1")
     @ApiResponse(responseCode = "200", description = "OK", content = 
@Content(schema = @Schema(implementation = 
AccountTransfersApiResourceSwagger.GetAccountTransfersTemplateResponse.class)))
     public AccountTransferData template(@BeanParam AccountTransSearchParam 
accountTransSearchParam) {
-
         
context.authenticatedUser().validateHasReadPermission(AccountTransfersApiConstants.ACCOUNT_TRANSFER_RESOURCE_NAME);

Review Comment:
   Please see other already migrated packages. Authorization should be 
configured where it belongs... and that is `SecurityConfig.java`. Using the 
platform security context service is bad practice anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to