budaidev commented on code in PR #6: URL: https://github.com/apache/fineract-loan-origination/pull/6#discussion_r3319080287
########## .gitignore: ########## @@ -0,0 +1,51 @@ +<!-- Review Comment: I don't think .gitignore should contain licence header, but even if it is, it uses hashtag comment style ########## .gitattributes: ########## @@ -0,0 +1,21 @@ +<!-- Review Comment: I don't think .gitattributes should contain licence header, but even if it is, it uses hashtag comment style ########## .gitattributes: ########## @@ -0,0 +1,21 @@ +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + Review Comment: we could add `* text=auto` as first rule just to keep everything consistent ########## .github/workflows/ci.yml: ########## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +name: Fineract LOS CI + +on: + push: + branches: [ "**" ] + pull_request: + branches: [ main ] + +jobs: + build: + name: Build and Verify + runs-on: ubuntu-latest + + permissions: + contents: read + + services: + postgres: + image: postgres:15 + env: + POSTGRES_DB: los_db + POSTGRES_USER: los_user Review Comment: the CI postgres user/password is different from the application.yml setup, CI step would fail without setting the DB_USERNAME/DB_PASSWORD env vars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
