vidakovic commented on code in PR #5903:
URL: https://github.com/apache/fineract/pull/5903#discussion_r3340071707
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/SchedulerJobHelper.java:
##########
@@ -147,7 +147,7 @@ public Map<String, Object> updateSchedulerJob(int jobId,
final boolean active) {
return response;
}
- public void updateSchedulerJob(long jobId, PutJobsJobIDRequest request) {
+ public void updateSchedulerJob(long jobId, UpdateJobRequest request) {
Review Comment:
Why not adding "jobId" to the request object? Having multiple parameters in
a function signature makes it over time brittle. If you only have the request
object as input parameter and tomorrow you add a new attribute to it then the
function stays the same doesn't trigger a refactoring fest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
