heissenberg06 commented on PR #5945: URL: https://github.com/apache/fineract/pull/5945#issuecomment-4633275648
> @heissenberg06 Would you mind to extend the refactor for the whole codebase or for per module at least? :) Thanks @adamsaghy! I've extended the refactor to cover the rest of the fineract-loan module — LoanProduct and LoanStatusChangeHistoryListener now use !isEmpty() as well, on top of the original LoanRepositoryWrapper change. That's all the java:S1155 occurrences in fineract-loan addressed. To keep this PR focused and easy to review, I'd suggest handling the other modules in separate follow-up PRs under the same ticket. Happy to proceed that way if it works for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
