adamsaghy commented on code in PR #5946:
URL: https://github.com/apache/fineract/pull/5946#discussion_r3374429238
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/provisioning/ProvisioningHelper.java:
##########
@@ -18,111 +18,73 @@
*/
package org.apache.fineract.integrationtests.common.provisioning;
-import com.google.gson.Gson;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.security.SecureRandom;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.util.HashMap;
+import java.util.List;
import java.util.Locale;
import java.util.Map;
+import org.apache.fineract.client.models.ProvisionEntryRequest;
+import org.apache.fineract.client.models.ProvisioningCategoryData;
import org.apache.fineract.integrationtests.common.Utils;
import org.apache.fineract.integrationtests.common.accounting.Account;
public final class ProvisioningHelper {
private static final SecureRandom rand = new SecureRandom();
- private ProvisioningHelper() {
+ private ProvisioningHelper() {}
- }
-
- // TODO: Rewrite to use fineract-client instead!
- // Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
- // org.apache.fineract.client.models.PostLoansLoanIdRequest)
- @Deprecated(forRemoval = true)
- @SuppressFBWarnings(value = {
- "DMI_RANDOM_USED_ONLY_ONCE" }, justification = "False positive for
random object created and used only once")
- public static Map createProvisioingCriteriaJson(ArrayList<Integer>
loanProducts, ArrayList categories, Account liability,
- Account expense) {
- final HashMap<String, Object> map = new HashMap<>();
- map.put("loanProducts", addLoanProducts(loanProducts));
- map.put("definitions", addProvisioningCategories(categories,
liability, expense));
+ public static Map<String, Object>
createProvisioningCriteriaJson(List<Integer> loanProducts,
List<ProvisioningCategoryData> categories,
Review Comment:
Do we still need this? It would be better to completely remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
