Aman-Mittal commented on code in PR #5965:
URL: https://github.com/apache/fineract/pull/5965#discussion_r3385674637
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java:
##########
@@ -187,7 +187,7 @@ public List<GLAccountData> retrieveAllGLAccounts(final
Integer accountClassifica
sql += " ORDER BY gl_code ASC";
final Object[] finalObjectArray = Arrays.copyOf(parameterArray,
arrayPos);
- return this.jdbcTemplate.query(sql, rm, (Object[])
finalObjectArray);// NOSONAR
Review Comment:
NOSONAR was used to suppress warings here. Just asking why unsafe cast was
used here to begin with?
Resolve this after answering
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java:
##########
@@ -187,7 +187,7 @@ public List<GLAccountData> retrieveAllGLAccounts(final
Integer accountClassifica
sql += " ORDER BY gl_code ASC";
final Object[] finalObjectArray = Arrays.copyOf(parameterArray,
arrayPos);
- return this.jdbcTemplate.query(sql, rm, (Object[])
finalObjectArray);// NOSONAR
Review Comment:
NOSONAR was used to suppress warnings here. Just asking why unsafe cast was
used here to begin with?
Resolve this after answering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
