DeathGun44 opened a new pull request, #5978: URL: https://github.com/apache/fineract/pull/5978
## Description Extends the RestAssured → Feign migration (PR 3 of the roadmap) to the Charges and Delinquency domains. **Key Changes:** * **Added `ChargeRequestBuilders`:** Static typed factories for `ChargeRequest` generation. * **Added `FeignChargesHelper`:** 14 pure-Feign methods for global (`ChargesApi`) and client-level (`ClientChargesApi`) charge management. * **Added `FeignDelinquencyLifecycleTest`:** 7 ordered E2E tests verifying delinquency range/bucket CRUD via native Feign. * **Fixed Swagger Spec:** Added 4 missing withdrawal fields to `PostChargesRequest` in `ChargesApiResourceSwagger`, ensuring `ChargeRequest` generation is accurate for PUT requests. * **Refactored Tests:** Swapped duplicated legacy `createCharge()` logic in 3 enricher/report tests with the new `chargesHelper.createLoanDisbursementCharge()`. **Note:** `LoanChargesApi` actions (add/pay/waive on specific loans) and Loan Delinquency actions are deferred to the upcoming `FeignLoanHelper` PR. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
