adamsaghy commented on code in PR #5940:
URL: https://github.com/apache/fineract/pull/5940#discussion_r3435575597
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeService.java:
##########
@@ -822,9 +828,9 @@ private void update(final LoanCharge loanCharge, final
BigDecimal amount, final
if (numberOfRepayments == null) {
numberOfRepayments =
loanCharge.getLoan().fetchNumberOfInstallmentsAfterExceptions();
}
-
loanCharge.setAmount(amount.multiply(BigDecimal.valueOf(numberOfRepayments)));
+
loanCharge.setAmount(loanCharge.minimumAndMaximumCap(amount.multiply(BigDecimal.valueOf(numberOfRepayments))));
Review Comment:
See no changes...no reply...
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeService.java:
##########
@@ -232,6 +232,11 @@ public void addLoanCharge(final Loan loan, final
LoanCharge loanCharge) {
update(loanCharge, chargeAmt, loanCharge.getDueLocalDate(), amount,
loan.fetchNumberOfInstallmentsAfterExceptions(),
totalChargeAmt);
+ // Skip zero-value charges
Review Comment:
See no changes...no reply...
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/accounts/api/AccountsApiResourceSwagger.java:
##########
@@ -465,15 +465,26 @@ public static final class
PostAccountsTypeAccountIdRequest {
private PostAccountsTypeAccountIdRequest() {}
+ @Schema(example = "en")
+ public String locale;
+ @Schema(example = "dd MMMM yyyy")
+ public String dateFormat;
+ @Schema(example = "01 January 2026")
+ public String activatedDate;
+ @Schema(example = "05 May 2026")
+ public String requestedDate;
+ @Schema(example = "01 January 2026")
+ public String closedDate;
+ @Schema(description = "Can represent either number of shares or
transaction IDs")
+ public Object requestedShares;
+
static final class PostAccountsRequestedShares {
private PostAccountsRequestedShares() {}
@Schema(example = "35")
public Long id;
}
-
- public Set<PostAccountsRequestedShares> requestedShares;
}
Review Comment:
See no changes...no reply...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
