DeathGun44 opened a new pull request, #6005: URL: https://github.com/apache/fineract/pull/6005
## Description Migrates 5 Tier 1 loan integration tests from `BaseLoanIntegrationTest` (REST-assured) to `FeignLoanTestBase` (Feign client). ### Migrated tests - `LoanPrepayAmountTest` - `LoanProductWithChargeOffBehaviourTest` - `LoanInterestRateFrequencyTest` - `LoanDueCalculationTest` - `FixedLengthLoanProductIntegrationTest` ### Infrastructure additions - Added `retrieveLoanProduct` and `updateLoanProduct` (typed) methods to `FeignLoanHelper` - Added `updateLoanProduct(Long, String)` raw JSON overload in `FeignLoanTestBase` for explicit null values (the `NON_NULL` ObjectMapper prevents typed null serialization) - Added REST-assured `requestSpec`/`responseSpec` to `FeignLoanTestBase` for raw JSON edge cases - Added `fixedLengthLoanProduct` template to `LoanProductTemplates` - Added payment allocation helpers and loan request builders to `LoanRequestBuilders` - Added schedule validation helpers to `LoanTestValidators` ### Bug fixes - `FeignClientHelper.createClient()` - use fixed past activation date (`04 March 2011`) matching `ClientHelper.DEFAULT_DATE` instead of real system date - `FeignBusinessDateHelper` - date format fixed to use `DATETIME_PATTERN` (`dd MMMM yyyy`) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
