aditinikam opened a new pull request, #6013: URL: https://github.com/apache/fineract/pull/6013
Migrate org.apache.fineract.portfolio.floatingrates (fineract-rates) to the new command-processing infrastructure (FINERACT-2169), mirroring the Staff gold-standard pattern. - FloatingRatesApiResource injects CommandDispatcher; POST/PUT build typed FloatingRateCreate/UpdateCommand and return typed POJOs (FloatingRateCreateResponse/FloatingRateUpdateResponse). @Produces hoisted to class level; inline read-permission checks removed from GETs. - Add typed command handlers (CommandHandler<Req,Res>, @Retry/@Transactional), FloatingRateWriteService(+Impl), FloatingRateUpdateRequest (distinct payload type for dispatcher routing), and typed validateForCreate/Update + FloatingRate.createNew/update overloads (JsonCommand-free). - Legacy write path kept in parallel (FloatingRateWritePlatformService, old NewCommandSourceHandler handlers, JsonCommand domain/validator methods). - Rename FloatingRatesReadPlatformService -> FloatingRatesReadService (+Impl) across all callers. - Add fineract-command dependency to fineract-rates; register write-service bean; add /api/*/floatingrates GET/POST/PUT authorization matchers to SecurityConfig (READ/CREATE/UPDATE_FLOATINGRATE). ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
