adamsaghy commented on code in PR #5967:
URL: https://github.com/apache/fineract/pull/5967#discussion_r3450904602
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/DepositProductReadPlatformServiceImpl.java:
##########
@@ -74,6 +78,9 @@ public Collection<DepositProductData>
retrieveAllForLookup(final DepositAccountT
sqlBuilder.append("select ");
sqlBuilder.append(DEPOSIT_PRODUCT_LOOKUP_MAPPER.schema());
sqlBuilder.append(" where sp.deposit_type_enum = ? ");
+ sqlBuilder.append(" and (sp.close_date is null or sp.close_date >= ");
Review Comment:
I dont think we should filter them out...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
