mansi75 opened a new pull request, #6031:
URL: https://github.com/apache/fineract/pull/6031

   ## Description
   
   This PR adds a new design document, `Event-driven architecture for modular 
design`, to the Fineract documentation (`fineract-doc`).
   
   The document describes the proposed approach for getting Fineract's module 
boundaries under control. Today, feature modules import each other's internal 
classes directly (e.g. loan reads savings entities, savings calls accounting 
services, accounting depends on organisation repositories), and nothing 
enforces the use of the existing `fineract-core` and `fineract-command` shared 
modules. The doc proposes making those two modules the only permitted 
cross-feature dependency — reads cross a boundary as a `fineract-core` 
interface returning a DTO, writes cross as a `fineract-command` command or 
domain event — and migrating all direct feature-to-feature imports to that 
model in phased, risk-ordered steps, with an ArchUnit rule activated in CI once 
the violation count reaches zero.
   
   Changes in this PR:
   - Add `fineract-doc/src/docs/en/modularization.adoc` (the design document).
   - Register it in `fineract-doc/src/docs/en/index.adoc` via an `include::` 
directive so it renders in the documentation build.
   
   This is a documentation-only change. There are no code, REST API, schema, or 
behavioural changes.
   
   Related JIRA: https://issues.apache.org/jira/browse/FINERACT-2644
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [ ] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made. — N/A: documentation-only change, no code paths to test. Verified 
locally with `./gradlew :fineract-doc:doc` (docs build green).
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes — N/A: no API changes.
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to