nidhiii128 commented on PR #6021: URL: https://github.com/apache/fineract/pull/6021#issuecomment-4798906703
Hi reviewers, quick note on the failing CI check: The only failing check is `run-api-backward-compatibility / api-compatibility-check`. This is caused by the removal of `@ApiResponse(responseCode = "200", ...)` annotations from the migrated controller methods, following the style guidance applied in prior reviews (Aleks flagged these as trivial/noisy in earlier PRs). Removing them drops the documented response schema from the OpenAPI spec, which `swagger-brake` then reports as a backward-incompatible change. I've gone with the style preference. The same expected failure pattern appears in the merged `StaffCreateCommand` migration reference. All 84 other checks are green: Happy to revert the `@ApiResponse` removal if the team prefers swagger-brake green over annotation cleanup. Otherwise, ready for review when you have time. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
