aditinikam opened a new pull request, #6038:
URL: https://github.com/apache/fineract/pull/6038
Migrate the Floating Rate module write path off the legacy
CommandWrapperBuilder -> logCommandSource -> @CommandType (JsonCommand)
pipeline onto the typed CommandDispatcher (CQRS) infrastructure, fully
JsonCommand-free.
- API resource injects CommandDispatcher and dispatches typed
FloatingRate{Create,Update}Command, returning typed responses.
- New typed FloatingRateWriteService + command handlers; FloatingRate domain
createNew/update and FloatingRateDataValidator retyped to operate on the
request DTOs (locale-aware date parsing via DateTimeFormatter).
- SecurityConfig gains POST/PUT /floatingrates matchers (CREATE/UPDATE)
since the logCommandSource permission check is gone; read endpoints and
FloatingRatesReadPlatformService are left untouched.
- Removed legacy FloatingRateWritePlatformService, @CommandType handlers,
and the CommandWrapperBuilder floating-rate methods.
- fineract-rates now depends on :fineract-command.
## Description
Describe the changes made and why they were made. (Ignore if these details
are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
