mansi75 opened a new pull request, #6044: URL: https://github.com/apache/fineract/pull/6044
## Description This PR adds a Spring Modulith based cross-feature boundary test that verifies, across every module in the codebase, that each feature module depends only on `fineract-core` and `fineract-command`. It is part of the ongoing modularization effort tracked under FINERACT-2645. The test (`AllModulesCrossFeatureBoundaryTest`) builds the Spring Modulith application model over `org.apache.fineract` and inspects the direct dependencies of every module. A referenced type is treated as allowed "foundation" only when it physically resides in `fineract-core` or `fineract-command`. This is decided by the artifact the type is loaded from (via its source URI), not by package name, because `fineract-core` holds relocated DTOs and enums under packages such as `organisation.*` and `portfolio.*`; a package-name check would wrongly flag those, whereas an artifact-based check classifies them correctly. The class provides: - `printAllModulesCrossFeatureDependencyReport` — a per-source-type report, for every module, showing each referenced feature package with its owning artifact and foundation/violation status. - `printModuleToModuleDependencyViolations` — a module-to-module rollup showing, for each source module, the other modules it depends on, the number of class-level edges into each, and the offending feature packages. - `noModuleMayDependOnAnotherFeatureModule` — the enforcement test that fails if any module references a type from another feature module, with a per-module breakdown to guide decoupling. Reporting output uses SLF4J rather than `System.out` to comply with the project's checkstyle rules. The approach uses pure Spring Modulith APIs and does not introduce ArchUnit assertions into the test logic. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
