KRYSTALM7 commented on code in PR #29: URL: https://github.com/apache/fineract-loan-origination/pull/29#discussion_r3487491828
########## src/main/java/org/apache/fineract/los/scoring/factors/DebtBurdenFactor.java: ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fineract.los.scoring.factors; + +import java.math.BigDecimal; +import java.math.RoundingMode; +import lombok.RequiredArgsConstructor; +import org.apache.fineract.los.scoring.ScoringFactor; +import org.apache.fineract.los.scoring.ScoringWeightsProperties; +import org.apache.fineract.los.scoring.model.ApplicantScoringProfile; +import org.apache.fineract.los.scoring.model.FactorScore; +import org.springframework.stereotype.Component; + +/** + * Evaluates the applicant's existing debt burden relative to monthly income. + * + * <p>Computes the Debt-to-Income (DTI) ratio: {@code existingLoanObligations / monthlyIncome}. + * Lower DTI means less of the applicant's income is already committed to debt, leaving more + * capacity to service a new loan. + * + * <p>Scoring bands (DTI = existingLoanObligations / monthlyIncome): + * + * <ul> + * <li>≤ 0.20 (up to 20% of income committed) → full points + * <li>≤ 0.35 → 75% of max points + * <li>≤ 0.50 → 50% of max points + * <li>≤ 0.65 → 25% of max points + * <li>> 0.65 → 0 points + * </ul> + * + * <p>If {@code monthlyIncome} is null or zero, scores 0 — cannot compute DTI without income. + * If {@code existingLoanObligations} is null or zero, the applicant has no existing debt and + * receives full points. + */ +@Component +@RequiredArgsConstructor +public class DebtBurdenFactor implements ScoringFactor { + + private static final String FACTOR_NAME = "debt-burden"; + + private final ScoringWeightsProperties weights; + + @Override + public FactorScore score(ApplicantScoringProfile profile) { + final int max = maxPoints(); + + BigDecimal income = profile.getMonthlyIncome(); + BigDecimal obligations = profile.getExistingLoanObligations(); + + if (income == null || income.compareTo(BigDecimal.ZERO) <= 0) { + return FactorScore.builder() + .points(0) + .maxPoints(max) + .explanation("Cannot evaluate debt burden without monthly income data.") + .build(); + } + + // No existing obligations — clean slate, full points + if (obligations == null || obligations.compareTo(BigDecimal.ZERO) <= 0) { + return FactorScore.builder() + .points(max) + .maxPoints(max) + .explanation("No existing loan obligations — full debt capacity available.") + .build(); + } + + // DTI = existingObligations / monthlyIncome + BigDecimal dti = obligations.divide(income, 4, RoundingMode.HALF_UP); Review Comment: added an explicit hasValidIncome() guard that checks income is present and strictly positive before any division happens. If it's not, the factor returns a zero score with an explanation instead of dividing. Same fix applied to IncomeLoanRatioFactor for the requestedAmount denominator. Pushed in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
