[
https://issues.apache.org/jira/browse/FINERACT-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krishna Mewara updated FINERACT-2649:
-------------------------------------
Description:
Migrate all ~118 loan integration tests currently extending
{{BaseLoanIntegrationTest}} to extend {{{}FeignLoanTestBase{}}}, replacing
REST-assured HTTP calls with the typed Feign client. This eliminates
REST-assured as a test dependency for loan tests and aligns with the project's
long-term goal of full Feign client adoption.
----
Target state:
* 0 test classes extend {{BaseLoanIntegrationTest}}
* All loan tests use the typed Feign client
* {{BaseLoanIntegrationTest}} can be deleted or deprecated
----
Approach
Split into 4 batch PRs ordered by infrastructure dependency complexity:
||PR||GitHub||~Classes||Scope||
|PR1|[#6005|https://github.com/apache/fineract/pull/6005] merged|5|Simple
lifecycle no GL accounting, no charges, no advanced features|
|PR2|[#6050|https://github.com/apache/fineract/pull/6050] in
review|34|Charge-off, fraud, delinquency, progressive, accrual, waive/refund,
reverse-replay|
|PR3|TBD|53|Reschedule, chargeback, cumulative/APA, client loan,
transaction-heavy tests|
|PR4|TBD|31|COB, inline COB, external asset owner, batch API, GL journals,
permissions, edge cases|
was:
Migrate all ~118 loan integration tests currently extending
{{BaseLoanIntegrationTest}} to extend {{{}FeignLoanTestBase{}}}, replacing
REST-assured HTTP calls with the typed Feign client. This eliminates
REST-assured as a test dependency for loan tests and aligns with the project's
long-term goal of full Feign client adoption.
----
Target state:
* 0 test classes extend {{BaseLoanIntegrationTest}}
* All loan tests use the typed Feign client
* {{BaseLoanIntegrationTest}} can be deleted or deprecated
----
Approach
Split into 4 batch PRs ordered by infrastructure dependency complexity:
||PR||GitHub||~Classes||Scope||
|PR1|[#6005|https://github.com/apache/fineract/pull/6005] merged|5|Simple
lifecycle no GL accounting, no charges, no advanced features|
|PR2| |34|Charge-off, fraud, delinquency, progressive, accrual, waive/refund,
reverse-replay|
|PR3|TBD|53|Reschedule, chargeback, cumulative/APA, client loan,
transaction-heavy tests|
|PR4|TBD|31|COB, inline COB, external asset owner, batch API, GL journals,
permissions, edge cases|
> Batch Migrate BaseLoanIntegrationTest Importers to FeignLoanTestBase
> --------------------------------------------------------------------
>
> Key: FINERACT-2649
> URL: https://issues.apache.org/jira/browse/FINERACT-2649
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Reporter: Krishna Mewara
> Assignee: Krishna Mewara
> Priority: Trivial
> Labels: feign-migration
>
> Migrate all ~118 loan integration tests currently extending
> {{BaseLoanIntegrationTest}} to extend {{{}FeignLoanTestBase{}}}, replacing
> REST-assured HTTP calls with the typed Feign client. This eliminates
> REST-assured as a test dependency for loan tests and aligns with the
> project's long-term goal of full Feign client adoption.
> ----
> Target state:
> * 0 test classes extend {{BaseLoanIntegrationTest}}
> * All loan tests use the typed Feign client
> * {{BaseLoanIntegrationTest}} can be deleted or deprecated
> ----
> Approach
> Split into 4 batch PRs ordered by infrastructure dependency complexity:
> ||PR||GitHub||~Classes||Scope||
> |PR1|[#6005|https://github.com/apache/fineract/pull/6005] merged|5|Simple
> lifecycle no GL accounting, no charges, no advanced features|
> |PR2|[#6050|https://github.com/apache/fineract/pull/6050] in
> review|34|Charge-off, fraud, delinquency, progressive, accrual, waive/refund,
> reverse-replay|
> |PR3|TBD|53|Reschedule, chargeback, cumulative/APA, client loan,
> transaction-heavy tests|
> |PR4|TBD|31|COB, inline COB, external asset owner, batch API, GL journals,
> permissions, edge cases|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
