adamsaghy commented on code in PR #6043:
URL: https://github.com/apache/fineract/pull/6043#discussion_r3491264242
##########
fineract-provider/src/main/java/org/apache/fineract/organisation/holiday/api/HolidaysApiResource.java:
##########
@@ -97,7 +97,7 @@ public String createNewHoliday(@Parameter(hidden = true)
final String apiRequest
@Path("{holidayId}")
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- @Operation(summary = "Activate a Holiday", description = "Always Holidays
are created in pending state. This API allows to activate a holiday.\n"
+ @Operation(summary = "Activate a Holiday", operationId =
"handleCommandsHoliday", description = "Always Holidays are created in pending
state. This API allows to activate a holiday.\n"
Review Comment:
`handleCommandsHoliday` sounds weird... i think simple `handleCommand` would
be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
