oluexpert99 commented on PR #6059: URL: https://github.com/apache/fineract/pull/6059#issuecomment-4855994020
> The principle to manipulate the json object which is the incoming request is wrong and should not be followed. > > If something was not provided, just ignore it... we are doing it in many situations already: `command.hasParameter` or `fromJsonHelper.parameterExists` Hi @adamsaghy I revamped this to ensure no more request-JSON manipulation. On modify, the schedule now recalculates from the loan's own state (buildScheduleGeneratorDTO(loan, null) + regenerateRepaymentSchedule(loan, dto)), exactly like the approval/reschedule/apply-holidays flows. An omitted field is simply ignored and its existing value flows through; nothing is written back to the request. Also, I dropped the redundant post-recalc recalculateAllCharges (regenerate already does it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
