DeathGun44 opened a new pull request, #6084: URL: https://github.com/apache/fineract/pull/6084
## Description This PR transitions **56 test classes** (encompassing approximately **277 test methods**) to utilize the Feign client, entirely removing their dependency on REST-assured. **Note on Behavior:** The core test behavior and assertions remain completely unchanged. This is strictly a refactor of the underlying HTTP client layer. ### Targeted commits I've split this work into **13 commits**, grouped logically by test area (reschedule, chargebacks, APA, down-payments, etc.) to keep things manageable for review. This will ensure that if CI fails or issues arise later, it is much easier to isolate and track down the specific batch that introduced the regression. ### Scope **Included in this PR:** * Comprehensive Loan Rescheduling and Re-aging tests (including Center/Group reschedules). * Chargeback integration scenarios (non-APA workflows, overpaid loans, payment type constraints). * Down-payment workflows (product configuration, transaction typing, undo disbursal, and repayment schedules). * Advanced Payment Allocation (APA) coverage for write-offs, transaction reprocessing, and external-id support. * Client loan lifecycle tests (credit balance refund, multiple disbursements, floating rates, and date validations). * Reverse-replay transaction relations and loan summary tests. * Standardization of `BigDecimal` precision assertions across migrated Feign tests. ### Infrastructure Enhancements This PR builds upon the shared Feign test infrastructure from earlier batches, adding and extending several utilities to streamline testing: * **`InternalLoanReAgeApi`**: Supports specific internal API flows related to the re-aging of loans. * **`FeignGroupCenterHelper`**: Provides utilities for managing group and center associations during loan testing. * **`FeignRawHttpHelper`**: Safely handles edge cases that require raw HTTP requests to bypass strict Swagger model limitations (e.g., floating rate properties), utilizing `fineract.it.url` securely. * **Business Date Context (`runAt`)**: Expanded the `FeignLoanTestBase` to cleanly execute nested operations under specific simulated business dates. * **Event Verification**: Integrated `Awaitility`-based assertions for robust verification of asynchronous business events. * **Shared Builders & Validators**: Expanded Feign loan helpers for external-ids, re-amortizations, write-offs, and credit allocations. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
