adamsaghy commented on code in PR #6042:
URL: https://github.com/apache/fineract/pull/6042#discussion_r3527318264
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java:
##########
@@ -461,7 +461,7 @@ private Collection<PortfolioAccountData>
getAccountLinkingOptions(final LoanAcco
@GET
@Path("{loanId}")
@Produces({ MediaType.APPLICATION_JSON })
- @Operation(summary = "Retrieve a Loan", description = "Note: template=true
parameter doesn't apply to this resource."
+ @Operation(summary = "Retrieve a Loan", operationId = "retrieveOneLoan",
description = "Note: template=true parameter doesn't apply to this resource."
Review Comment:
We should be consistent, so if we are changing the `retrieveLoan` to
`retrieveOneLoan`, we should change the `retrieveLoan` to
`retrieveOneLoanByExternalId`,no?
Lets change both or non of them please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
