adamsaghy commented on code in PR #6082:
URL: https://github.com/apache/fineract/pull/6082#discussion_r3529059216
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanTransactionReprocessingServiceImpl.java:
##########
@@ -136,6 +137,38 @@ public void reprocessTransactions(final WorkingCapitalLoan
loan, final List<Work
amortizationScheduleWriteService.rebuildScheduleFromPrincipalPayments(loan,
principalPayments);
}
+ @Override
+ public void reprocessAfterBackdatedTransaction(final WorkingCapitalLoan
loan,
+ final List<WorkingCapitalLoanTransaction> allTransactions) {
+ final List<WorkingCapitalLoanTransaction> replayable =
replayableInChronologicalOrder(allTransactions);
+ reprocessReplayableTransactions(loan, replayable);
+
delinquencyRangeScheduleService.reprocessScheduleFromTransactions(loan,
replayable);
+ }
+
+ @Override
+ public void reprocessAfterUndo(final WorkingCapitalLoan loan) {
+ final List<WorkingCapitalLoanTransaction> allTransactions =
transactionRepository
+ .findByWcLoan_IdOrderByTransactionDateAscIdAsc(loan.getId());
+ final List<WorkingCapitalLoanTransaction> replayable =
replayableInChronologicalOrder(allTransactions);
+ final List<WorkingCapitalLoanCharge> charges =
chargeRepository.findByLoanIdAndActiveTrueOrderByDueDateAscIdAsc(loan.getId());
+ if (!charges.isEmpty()) {
+ reprocessReplayableTransactions(loan, replayable);
+ }
+
delinquencyRangeScheduleService.reprocessScheduleFromTransactions(loan,
replayable);
Review Comment:
`delinquencyRangeScheduleService.reprocessScheduleFromTransactions` and
`WorkingCapitalLoanTransactionReprocessingServiceImpl.reprocessDelinquencySchedule`
seems equivalent and hence latter can be removed safely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
