vidakovic commented on code in PR #6049:
URL: https://github.com/apache/fineract/pull/6049#discussion_r3538028476
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java:
##########
@@ -265,14 +264,14 @@ public static PostClientsResponse createClient(final
RequestSpecification reques
// Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
// org.apache.fineract.client.models.PostLoansLoanIdRequest)
@Deprecated(forRemoval = true)
- public static PostClientClientIdAddressesResponse
createClientAddress(final RequestSpecification requestSpec,
+ public static HashMap<String, Object> createClientAddress(final
RequestSpecification requestSpec,
Review Comment:
This looks wrong. We lost the type information and the whole idea of this
code change is to have proper types in the first place. Something is wrong in
the REST API resource class!
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientTest.java:
##########
@@ -254,10 +253,10 @@ public void
testClientAddressCreationWorksAfterClientIsCreated() {
// when
ClientAddressRequest request = new
ClientAddressRequest().postalCode(postalCode).city(city).countryId(Long.valueOf(countryId))
.stateProvinceId(Long.valueOf(stateId)).isActive(addressIsActive);
- PostClientClientIdAddressesResponse response =
ClientHelper.createClientAddress(requestSpec, responseSpec,
clientId.longValue(),
- addressTypeId, request);
+ HashMap<String, Object> response =
ClientHelper.createClientAddress(requestSpec, responseSpec,
clientId.longValue(), addressTypeId,
Review Comment:
This looks wrong. We lost the type information and the whole idea of this
code change is to have proper types in the first place. Something is wrong in
the REST API resource class!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
