mansi75 opened a new pull request, #6110: URL: https://github.com/apache/fineract/pull/6110
## Description This PR fixes the Spring Modulith cross-feature dependency violation for the Client module. The Client feature was directly depending on classes from other feature modules, which violates the intended module boundaries. To address this, the required client-facing contracts and shared types have been moved/introduced in `fineract-core`, and the Client module now depends only on allowed shared modules such as `fineract-core` and `fineract-command`. Main changes include: - Decoupled the Client feature from direct cross-feature implementation dependencies. - Introduced client-specific service interfaces/contracts in `fineract-core`. - Moved shared domain/data/event types needed by Client into `fineract-core`. - Updated dependent implementations in feature modules such as loan, savings, charge, collateral, note, accounting, staff, working days, holidays, and data queries to use the new boundaries. - Added a Spring Modulith boundary test for the Client package to prevent future cross-feature dependency regressions. - Updated Gradle dependencies so the Client feature no longer depends directly on unrelated feature modules. This keeps the Client module aligned with the intended modular architecture by ensuring it depends only on `core` and `command`-level abstractions instead of directly depending on other feature implementations. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
