budaidev commented on code in PR #6109:
URL: https://github.com/apache/fineract/pull/6109#discussion_r3552635457
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/domain/WorkingCapitalLoanBreachSchedule.java:
##########
@@ -71,4 +71,18 @@ public class WorkingCapitalLoanBreachSchedule extends
AbstractAuditableWithUTCDa
@Column(name = "breach")
private Boolean breach;
+ @Column(name = "reset", nullable = false)
+ private boolean reset;
+
+ public void reset() {
+ this.reset = true;
+ this.breach = null;
+ this.nearBreach = null;
+ this.outstandingAmount = null;
+ this.paidAmount = null;
+ }
+
+ public BigDecimal getMinPaymentAmount() {
+ return reset ? null : this.minPaymentAmount;
Review Comment:
this might cause issue down the line, most probably in the
WorkingCapitalLoanNearBreachEvaluationServiceImpl.evaluatePeriod, if there is
no null check
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanActiveBreachResetResolver.java:
##########
@@ -39,71 +37,25 @@ public class WorkingCapitalLoanActiveBreachResetResolver {
private final WorkingCapitalLoanBreachActionRepository
breachActionRepository;
public Optional<WorkingCapitalLoanBreachAction>
findLatestActiveReset(final Long workingCapitalLoanId) {
- return findLatestActiveReset(workingCapitalLoanId, null);
- }
-
- public Optional<LocalDate> findLatestActiveResetDate(final Long
workingCapitalLoanId) {
- return
findLatestActiveReset(workingCapitalLoanId).map(WorkingCapitalLoanBreachAction::getStartDate);
- }
-
- public Optional<WorkingCapitalLoanBreachAction>
findLatestActiveReset(final Long workingCapitalLoanId,
- final Long maxActionIdExclusive) {
- if (workingCapitalLoanId == null) {
- return Optional.empty();
- }
- final List<WorkingCapitalLoanBreachAction> actions =
loadActions(workingCapitalLoanId, maxActionIdExclusive);
- final Optional<Long> latestActiveResetId =
findLatestActiveResetId(actions);
- return latestActiveResetId
- .flatMap(activeResetId -> actions.stream().filter(action ->
Objects.equals(action.getId(), activeResetId)).findFirst());
+ List<WorkingCapitalLoanBreachAction> filtereredList =
breachActionRepository.findByLoanAndActionType(workingCapitalLoanId,
+ List.of(WorkingCapitalLoanBreachActionType.RESET,
WorkingCapitalLoanBreachActionType.UNDO_RESET));
+ Deque<WorkingCapitalLoanBreachAction> stack = new ArrayDeque<>();
+ filtereredList.forEach(action -> {
+ if
(action.getAction().equals(WorkingCapitalLoanBreachActionType.RESET)) {
+ stack.push(action);
+ } else if
(action.getAction().equals(WorkingCapitalLoanBreachActionType.UNDO_RESET)) {
+ stack.pop();
Review Comment:
what happens if the stack is already empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
