adamsaghy commented on code in PR #6090:
URL: https://github.com/apache/fineract/pull/6090#discussion_r3569379863
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/XBRLIntegrationTest.java:
##########
@@ -64,4 +64,28 @@ private void verifyTaxonomyList(final ArrayList<HashMap>
taxonomyList) {
assertEquals("AdministrativeExpense", taxonomyList.get(0).get("name"),
"Checking for the 1st taxonomy");
}
+ @Test
+ public void shouldSerializeMixXBRLReportToXMLNatively() throws Exception {
Review Comment:
This looks to me a dummy test case... it does not test anything useful in my
understanding...
Would you mind to write an integration test which calls the relevant API and
checks whether the returned XML matches with the one that was created before
and after this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
