Cocoa-Puffs commented on code in PR #6105:
URL: https://github.com/apache/fineract/pull/6105#discussion_r3578777550
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/serialization/WorkingCapitalLoanChargeDataValidator.java:
##########
@@ -75,6 +76,10 @@ public void validateChargeAdjustmentRequest(final String
json) {
.extractLocalDateNamed(WorkingCapitalLoanChargeConstants.transactionDateParamName,
element);
baseDataValidator.reset().parameter(WorkingCapitalLoanChargeConstants.transactionDateParamName).value(transactionDate)
.notBlank();
+ if (transactionDate != null &&
!transactionDate.isEqual(DateUtils.getBusinessLocalDate())) {
+
baseDataValidator.reset().parameter(WorkingCapitalLoanChargeConstants.transactionDateParamName)
+ .failWithCode("must.be.the.business.date");
Review Comment:
I removed the validation entirely, as we no longer accept transaction date
as a valid parameter for charge adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
