Aman-Mittal commented on code in PR #6133:
URL: https://github.com/apache/fineract/pull/6133#discussion_r3584965232
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java:
##########
@@ -159,6 +169,25 @@ public CommandProcessingResult modifyLoanApplicationById(
return modifyLoanApplication(loanId, null, apiRequestBodyAsJson);
}
+ @PUT
+ @Path("{loanId}/mark-as-fraud")
+ @Consumes({ MediaType.APPLICATION_JSON })
+ @Produces({ MediaType.APPLICATION_JSON })
+ @Operation(operationId = "markWorkingCapitalLoanAsFraud", summary = "Mark
or unmark a Working Capital Loan as fraudulent", description = "Flags the loan
as fraudulent. When the loan is later charged off, a fraudulent loan is routed
to the charge-off fraud expense account instead of the regular charge-off
expense account. Does not change the loan status.")
+ @RequestBody(required = true, content = @Content(schema =
@Schema(implementation = MarkWorkingCapitalLoanAsFraudRequest.class)))
+ @ApiResponses({
Review Comment:
@ ApiResponses(
Use ApiResponse( only or use multiple ApiResponse annotation in case of
multiple
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResourceSwagger.java:
##########
@@ -340,7 +340,8 @@ private GetWorkingCapitalLoanSummary() {}
public Boolean enableInstallmentLevelDelinquency;
@Schema(description = "List of originators associated with this loan")
public List<GetWorkingCapitalLoansLoanIdOriginatorData> originators;
- @Schema(description = "Fraud flag. Placeholder: null until the WCP
fraud feature is implemented")
+ @Schema(description = "Fraud flag. True when the loan has been marked
as fraudulent via the mark-as-fraud command; "
+ + "a charged-off fraudulent loan is routed to the charge-off
fraud expense account", example = "false")
Review Comment:
minor: TextBlock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]