adamsaghy commented on PR #6078: URL: https://github.com/apache/fineract/pull/6078#issuecomment-4980095837
@oluexpert99 I like the idea (based on FINERACT-2672) but i am missing a couple things: - No paginated fetching of standing instructions, it would make sense to fetch in chunks of 100 entries - I would consider allowing to try to execute the whole chunk in 1 transaction, if any of them fails, we can fallback to save each one in separate transactions - I would consider process them parallel (standing instructions might need to be grouped together by `from account` or `to account` to avoid locking issues) -> I would also introduce retry mechanism (Retry4j) to automatically retry them before we mark it as failed - We might want to consider rewriting this whole logic to rather use Spring Batch remote worker capabilities (better retry mechanism, better parallelization and easier chunk usage) - I liked the idea of `next run date`. Would you mind to move this whole idea and conversation to the Fineract DEV mail list? It might be interesting conversation and we can finalize the appropriate design over there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
