adamsaghy commented on code in PR #6084:
URL: https://github.com/apache/fineract/pull/6084#discussion_r3588062062
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java:
##########
@@ -162,7 +162,7 @@ public String
retrieveTransactionTemplate(@PathParam("loanId") @Parameter(descri
+ "\n" + "loans/1/transactions/template?command=charge-off" + "\n"
+ "loans/1/transactions/template?command=downPayment" + "\n"
+ "loans/1/transactions/template?command=interest-refund")
@ApiResponses({
- @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
LoanTransactionsApiResourceSwagger.GetLoansLoanIdTransactionsTemplateResponse.class)))
})
Review Comment:
At this point, if not necessarily i would not change this. (maximum if some
fields are missing, add them to the swagger definition).
This story should not do any changes in PROD code, but only refactoring
testing implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]