paultofunmi opened a new pull request, #141: URL: https://github.com/apache/fineract-backoffice-ui/pull/141
## Summary Implements #117: the sidebar now renders from `NavigationConfigService.filteredNavItems()` instead of a hard-coded, directive-gated template. - `sidebar.component.ts`: ~1200 lines of static `<li>` markup replaced with a recursive `ng-template` + `ngTemplateOutlet`, handling leaf items, groups, and dividers at any nesting depth. - Removed `*appHasPermission`/`*appInstitutionFeature` usage from this file — filtering is now centralized in `NavigationConfigService`. The directives themselves are untouched and still used elsewhere (action buttons, etc.). - No new gates, no behavior changes — purely a rendering-source swap. ## Testing - Unit: 580/580 passing, no spec changes needed - Build: clean, no new warnings - Lint / format: clean - E2E: ran `feature-coverage.spec.ts`, `rbac-feature-flag.spec.ts`, `all-functions-read-shortcut.spec.ts` on both this branch and pre-#117 `main` — **identical failure set on both** (14 pre-existing failures from the Angular 22/MFE upgrade, unrelated to this change). Confirms zero regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
