adamsaghy commented on code in PR #6151:
URL: https://github.com/apache/fineract/pull/6151#discussion_r3620793943
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/data/WorkingCapitalLoanTransactionData.java:
##########
@@ -57,4 +58,5 @@ public class WorkingCapitalLoanTransactionData implements
Serializable {
private BigDecimal principalPortion;
private BigDecimal feeChargesPortion;
private BigDecimal penaltyChargesPortion;
+ private Collection<WorkingCapitalLoanChargePaidByData> chargePaidByList;
Review Comment:
No `Collection`, use `List`!
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/repository/WorkingCapitalLoanChargePaidByRepository.java:
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.workingcapitalloan.repository;
+
+import java.util.Collection;
+import java.util.List;
+import
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoanChargePaidBy;
+import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
+
+public interface WorkingCapitalLoanChargePaidByRepository extends
JpaRepository<WorkingCapitalLoanChargePaidBy, Long> {
+
+ void deleteByWcLoanTransaction_WcLoan_Id(Long loanId);
+
+ @Query("""
+ select paidBy from WorkingCapitalLoanChargePaidBy paidBy
+ join fetch paidBy.wcLoanTransaction transaction
+ join fetch paidBy.wcLoanCharge loanCharge
+ join fetch loanCharge.charge
+ where transaction.id in :transactionIds
+ order by paidBy.id desc
+ """)
+ List<WorkingCapitalLoanChargePaidBy>
findByTransactionIdIn(@Param("transactionIds") Collection<Long> transactionIds);
Review Comment:
No `Collection`, use `List`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
