oleksii-novikov-onix commented on code in PR #6140:
URL: https://github.com/apache/fineract/pull/6140#discussion_r3623051394
##########
fineract-avro-schemas/src/main/avro/workingcapitalloan/v1/WorkingCapitalLoanAccountDataV1.avsc:
##########
@@ -0,0 +1,445 @@
+{
+ "name": "WorkingCapitalLoanAccountDataV1",
+ "namespace": "org.apache.fineract.avro.workingcapitalloan.v1",
+ "type": "record",
+ "fields": [
+ {
+ "default": null,
+ "name": "id",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "accountNo",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "externalId",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "status",
+ "type": [
+ "null",
+ "org.apache.fineract.avro.loan.v1.LoanStatusEnumDataV1"
+ ]
+ },
+ {
+ "default": null,
+ "name": "clientId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "clientAccountNo",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "clientName",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "clientOfficeId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "clientExternalId",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "loanProductId",
+ "type": [
+ "null",
+ "long"
+ ]
+ },
+ {
+ "default": null,
+ "name": "loanProductName",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "loanProductDescription",
+ "type": [
+ "null",
+ "string"
+ ]
+ },
+ {
+ "default": null,
+ "name": "product",
+ "doc": "Filled for the event, unlike the legacy loan event which
leaves product null.",
Review Comment:
For regular loans - yes, we have the product field in the avro schema, but
we are not setting it at the serializer level. I have fixed this behavior for
wc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
