adamsaghy commented on code in PR #6128:
URL: https://github.com/apache/fineract/pull/6128#discussion_r3639987726


##########
fineract-core/src/main/java/org/apache/fineract/commands/domain/CommandSourceRepository.java:
##########
@@ -29,6 +30,21 @@ public interface CommandSourceRepository extends 
JpaRepository<CommandSource, Lo
 
     CommandSource findByActionNameAndEntityNameAndIdempotencyKey(String 
actionName, String entityName, String idempotencyKey);
 
+    @Query(value = """
+            select distinct c.* from m_portfolio_command_source c
+            where upper(c.action_name) = upper(?1)
+            and upper(c.entity_name) = upper(?2)
+            and (
+                c.resource_id = ?3

Review Comment:
   why ordinal? i think param name like "entityName" would make more sense for 
readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to