aditinikam opened a new pull request, #6167:
URL: https://github.com/apache/fineract/pull/6167
Migrate the charge definition module (/v1/charges) to the typed
command-processing infrastructure, removing the legacy JsonCommand write path
entirely (CQRS-only), following the conventions established by the Staff and
Floating Rate modules.
Write path
- ChargesApiResource POST/PUT/DELETE build typed Charge{Create,Update,
Delete}Command and dispatch through CommandDispatcher, returning typed
responses; the update response still carries the `changes` map
- add ChargeWriteService(+Impl), typed command handlers and request /
response DTOs under portfolio.charge.data
- applyChanges() lives in the write service rather than on the entity, so
the entity no longer consumes DTOs; Charge.fromJson and
Charge.update(JsonCommand) are gone
- delete ChargeWritePlatformService(+Impl), the @CommandType handlers, the
JSON deserializer and the CommandWrapperBuilder charge methods
Validation
- the programmatic deserializer is replaced by declarative Jakarta Bean
Validation: field constraints on the request DTOs plus the class-level
@ValidChargeCreate / @ValidChargeUpdate constraints for the cross-field and
chargeAppliesTo-driven rules
- ChargeUpdateValidator is repository-backed because the legacy path
validated the charge state after the update had been applied; it now validates
the merged (post-update) values instead
- messages live in fineract-validation ValidationMessages.properties
Read path
- ChargeReadPlatformService is renamed to ChargeReadService, the inline
permission checks are dropped and read authorization moves to SecurityConfig
matchers alongside the write ones
The generated client models follow the typed signatures, so the charge
operations in the integration and end-to-end tests are updated to
ChargeCreateRequest / ChargeCreateResponse / ChargeUpdateRequest /
ChargeUpdateResponse / ChargeDeleteResponse / ChargeData. The previously
undocumented `template` query parameter of GET /charges/{chargeId} is now part
of the API contract.
## Description
Describe the changes made and why they were made. (Ignore if these details
are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
