AshharAhmadKhan opened a new pull request, #6170: URL: https://github.com/apache/fineract/pull/6170
## JIRA - https://issues.apache.org/jira/browse/FINERACT-2515 ## Problem Three files (`LoanInstallmentCharge.java`, `LoanTransaction.java`, `DuplicateGuarantorException.java`) contained stale `// TODO Auto-generated...` stub comments left over from IDE code generation, despite the implementations being complete. Two prior PRs attempted to address this but each covered only these same 3 files: - #5672 (FINERACT-2515, KRYSTALM7) - #5844 (FINERACT-2346, Harshdhall01) Both were converted to draft after a maintainer requested the scope be widened to cover all instances of this pattern across the codebase, and both stalled without further updates. ## Fix Removes the same stub comments from the original 3 files plus 11 additional files across `fineract-loan`, `fineract-provider`, `fineract-rates`, and `fineract-savings`, covering the full scope requested on #5672 and #5844. Files touched: - `LoanInstallmentCharge.java` - `LoanTransaction.java` - `DuplicateGuarantorException.java` - `LoanProductTrancheDetails.java` - `AccrualBasedAccountingProcessorForLoan.java` - `JournalEntriesWorkbookPopulator.java` - `ExternalServiceWritePlatformServiceJpaRepositoryImpl.java` - `ExternalServicesReadPlatformServiceImpl.java` - `TellerWritePlatformServiceJpaImpl.java` - `AccountTransfersReadPlatformServiceImpl.java` - `AccountTransfersWritePlatformServiceImpl.java` - `PortfolioAccountReadPlatformServiceImpl.java` - `FloatingRateData.java` - `DepositAccountInterestIncentive.java` No functional changes. Comment removal only. ## Overlap with prior PRs This PR's diff is a superset of both #5672 and #5844. Recommend closing both as superseded once this is merged, to avoid duplicate review of the same 3 files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
