avivijay19 opened a new pull request, #6175:
URL: https://github.com/apache/fineract/pull/6175

   ## Description
   
   Extracted from #6069, where review asked for these e2e changes to be raised 
in a separate PR since they are not part of the Spring Boot upgrade itself.
   
   - When an event assertion times out, the step now queries the internal 
external events endpoint and logs whether the event was never persisted to 
`m_external_event` or was persisted but never delivered to the broker. A 
timeout alone cannot tell these two stages apart, which makes intermittent CI 
failures hard to attribute. Controlled by `EVENT_FAILURE_DIAGNOSTICS_ENABLED`, 
off by default and set only in the e2e workflow, and it only runs after an 
assertion has already failed, so passing runs are unaffected.
   - `loanAccountDataV1Check` consumes the latest received event of the 
asserted type, which can be a stale predecessor when earlier steps raised 
events of the same type for the same loan. The verification is now retried so 
each attempt consumes the next event as it arrives.
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [x] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [x] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [x] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to