avivijay19 commented on code in PR #6069:
URL: https://github.com/apache/fineract/pull/6069#discussion_r3649807083
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/increasedateby1day/increasebusinessdateby1day/IncreaseBusinessDateBy1DayTasklet.java:
##########
@@ -39,7 +41,13 @@ public class IncreaseBusinessDateBy1DayTasklet implements
Tasklet {
@Override
public RepeatStatus execute(StepContribution contribution, ChunkContext
chunkContext) throws Exception {
if (configurationDomainService.isBusinessDateEnabled()) {
-
businessDateWritePlatformService.increaseDateByTypeByOneDay(BusinessDateType.BUSINESS_DATE);
Review Comment:
Raised as #6176.
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/increasedateby1day/increasecobdateby1day/IncreaseCobDateBy1DayTasklet.java:
##########
@@ -39,7 +41,13 @@ public class IncreaseCobDateBy1DayTasklet implements Tasklet
{
@Override
public RepeatStatus execute(StepContribution contribution, ChunkContext
chunkContext) throws Exception {
if (configurationDomainService.isBusinessDateEnabled()) {
-
businessDateWritePlatformService.increaseDateByTypeByOneDay(BusinessDateType.COB_DATE);
+ try {
Review Comment:
Raised as #6176.
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/jobs/service/increasedateby1day/increasebusinessdateby1day/IncreaseBusinessDateBy1DayTaskletTest.java:
##########
@@ -77,4 +80,27 @@ public void
shouldBusinessDateJobBeProcessedWhenBusinessDateIsEnabled() throws E
assertEquals(RepeatStatus.FINISHED, repeatStatus);
}
+ @Test
+ public void shouldRetryOnceWhenConcurrentDateCreationFails() throws
Exception {
Review Comment:
Raised as #6176.
##########
fineract-provider/src/test/java/org/apache/fineract/infrastructure/jobs/service/increasedateby1day/increasecobdateby1day/IncreaseCobDateBy1DayTaskletTest.java:
##########
@@ -77,4 +80,27 @@ public void
shouldBusinessDateJobBeProcessedWhenBusinessDateIsEnabled() throws E
assertEquals(RepeatStatus.FINISHED, repeatStatus);
}
+ @Test
+ public void shouldRetryOnceWhenConcurrentDateCreationFails() throws
Exception {
Review Comment:
Raised as #6176.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
