Ashhar Ahmad Khan created FINERACT-2707:
-------------------------------------------
Summary: Email campaign JSON parsing failures are silently
swallowed instead of logged
Key: FINERACT-2707
URL: https://issues.apache.org/jira/browse/FINERACT-2707
Project: Apache Fineract
Issue Type: Bug
Reporter: Ashhar Ahmad Khan
In {{{}EmailCampaignWritePlatformCommandHandlerImpl{}}}, three methods catch
{{IOException}} from JSON parsing and do nothing with it. No log, no rethrow.
The exception disappears silently.
Affected methods:
* {{insertDirectCampaignIntoEmailOutboundTable(Loan, EmailCampaign, HashMap)}}
* {{insertDirectCampaignIntoEmailOutboundTable(String, String, String, String,
Long)}} (private overload)
* {{previewMessage(JsonQuery)}}
Both public callers of the first method loop over multiple campaigns in a
single pass ({{{}EmailCampaignDomainServiceImpl{}}} and the scheduled
{{{}UpdateEmailOutboundWithCampaignMessageTasklet{}}}). Throwing from inside
the loop would abort processing for every other campaign in that batch, so the
fix is to log the failure with context and continue, matching the existing
pattern already used in the SMS campaign equivalents
({{{}SmsCampaignDomainServiceImpl{}}},
{{{}SmsCampaignWritePlatformServiceJpaImpl{}}}).
No functional change otherwise. Comment removal plus a log statement only.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
