oluexpert99 opened a new pull request, #6182:
URL: https://github.com/apache/fineract/pull/6182
- GET /v1/recurringdepositaccounts/downloadtemplate returned HTTP 500
on any tenant
holding a recurring-deposit product with no minimum-deposit-term
type:
RecurringDepositProductSheetPopulator.populate writes the
min-deposit-term-type cell
through an unguarded product.getMinDepositTermType().getValue(), so
a null term type
throws and the whole template download fails. The template is
unusable for the entire
tenant and there is no API-side workaround.
- The field is optional on the product, and every sibling optional
field in the same loop
(min/max deposit amount, min/max deposit term, lock-in period,
pre-closure penal
interest) is already null-guarded. The fixed-deposit product sheet
populator guards the
equivalent field too, so this is an inconsistency between two
sibling populators rather
than a deliberate requirement.
- Guard the write like its siblings: a product without a
minimum-deposit-term type leaves
that lookup cell blank instead of failing the download. Nothing
changes for products
that do carry one.
- Add a unit test (RecurringDepositProductSheetPopulatorTest) covering
a product whose
term type is null: it fails on the unfixed code with the exact
production NPE and
asserts the product sheet is still written.
## Description
Describe the changes made and why they were made. (Ignore if these details
are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
- [ ] If merging this PR resolves a JIRA issue, I will mark that issue as
resolved and set "Fix Version/s" appropriately.
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
